| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046 |
- """
- Tests for various Pyflakes behavior.
- """
- from sys import version_info
- from pyflakes import messages as m
- from pyflakes.test.harness import TestCase, skip, skipIf
- class Test(TestCase):
- def test_duplicateArgs(self):
- self.flakes('def fu(bar, bar): pass', m.DuplicateArgument)
- def test_localReferencedBeforeAssignment(self):
- self.flakes('''
- a = 1
- def f():
- a; a=1
- f()
- ''', m.UndefinedLocal, m.UnusedVariable)
- def test_redefinedInGenerator(self):
- """
- Test that reusing a variable in a generator does not raise
- a warning.
- """
- self.flakes('''
- a = 1
- (1 for a, b in [(1, 2)])
- ''')
- self.flakes('''
- class A:
- a = 1
- list(1 for a, b in [(1, 2)])
- ''')
- self.flakes('''
- def f():
- a = 1
- (1 for a, b in [(1, 2)])
- ''', m.UnusedVariable)
- self.flakes('''
- (1 for a, b in [(1, 2)])
- (1 for a, b in [(1, 2)])
- ''')
- self.flakes('''
- for a, b in [(1, 2)]:
- pass
- (1 for a, b in [(1, 2)])
- ''')
- def test_redefinedInSetComprehension(self):
- """
- Test that reusing a variable in a set comprehension does not raise
- a warning.
- """
- self.flakes('''
- a = 1
- {1 for a, b in [(1, 2)]}
- ''')
- self.flakes('''
- class A:
- a = 1
- {1 for a, b in [(1, 2)]}
- ''')
- self.flakes('''
- def f():
- a = 1
- {1 for a, b in [(1, 2)]}
- ''', m.UnusedVariable)
- self.flakes('''
- {1 for a, b in [(1, 2)]}
- {1 for a, b in [(1, 2)]}
- ''')
- self.flakes('''
- for a, b in [(1, 2)]:
- pass
- {1 for a, b in [(1, 2)]}
- ''')
- def test_redefinedInDictComprehension(self):
- """
- Test that reusing a variable in a dict comprehension does not raise
- a warning.
- """
- self.flakes('''
- a = 1
- {1: 42 for a, b in [(1, 2)]}
- ''')
- self.flakes('''
- class A:
- a = 1
- {1: 42 for a, b in [(1, 2)]}
- ''')
- self.flakes('''
- def f():
- a = 1
- {1: 42 for a, b in [(1, 2)]}
- ''', m.UnusedVariable)
- self.flakes('''
- {1: 42 for a, b in [(1, 2)]}
- {1: 42 for a, b in [(1, 2)]}
- ''')
- self.flakes('''
- for a, b in [(1, 2)]:
- pass
- {1: 42 for a, b in [(1, 2)]}
- ''')
- def test_redefinedFunction(self):
- """
- Test that shadowing a function definition with another one raises a
- warning.
- """
- self.flakes('''
- def a(): pass
- def a(): pass
- ''', m.RedefinedWhileUnused)
- def test_redefined_function_shadows_variable(self):
- self.flakes('''
- x = 1
- def x(): pass
- ''', m.RedefinedWhileUnused)
- def test_redefinedUnderscoreFunction(self):
- """
- Test that shadowing a function definition named with underscore doesn't
- raise anything.
- """
- self.flakes('''
- def _(): pass
- def _(): pass
- ''')
- def test_redefinedUnderscoreImportation(self):
- """
- Test that shadowing an underscore importation raises a warning.
- """
- self.flakes('''
- from .i18n import _
- def _(): pass
- ''', m.RedefinedWhileUnused)
- def test_redefinedClassFunction(self):
- """
- Test that shadowing a function definition in a class suite with another
- one raises a warning.
- """
- self.flakes('''
- class A:
- def a(): pass
- def a(): pass
- ''', m.RedefinedWhileUnused)
- def test_redefinedIfElseFunction(self):
- """
- Test that shadowing a function definition twice in an if
- and else block does not raise a warning.
- """
- self.flakes('''
- if True:
- def a(): pass
- else:
- def a(): pass
- ''')
- def test_redefinedIfFunction(self):
- """
- Test that shadowing a function definition within an if block
- raises a warning.
- """
- self.flakes('''
- if True:
- def a(): pass
- def a(): pass
- ''', m.RedefinedWhileUnused)
- def test_redefinedTryExceptFunction(self):
- """
- Test that shadowing a function definition twice in try
- and except block does not raise a warning.
- """
- self.flakes('''
- try:
- def a(): pass
- except:
- def a(): pass
- ''')
- def test_redefinedTryFunction(self):
- """
- Test that shadowing a function definition within a try block
- raises a warning.
- """
- self.flakes('''
- try:
- def a(): pass
- def a(): pass
- except:
- pass
- ''', m.RedefinedWhileUnused)
- def test_redefinedIfElseInListComp(self):
- """
- Test that shadowing a variable in a list comprehension in
- an if and else block does not raise a warning.
- """
- self.flakes('''
- if False:
- a = 1
- else:
- [a for a in '12']
- ''')
- def test_functionDecorator(self):
- """
- Test that shadowing a function definition with a decorated version of
- that function does not raise a warning.
- """
- self.flakes('''
- from somewhere import somedecorator
- def a(): pass
- a = somedecorator(a)
- ''')
- def test_classFunctionDecorator(self):
- """
- Test that shadowing a function definition in a class suite with a
- decorated version of that function does not raise a warning.
- """
- self.flakes('''
- class A:
- def a(): pass
- a = classmethod(a)
- ''')
- def test_modernProperty(self):
- self.flakes("""
- class A:
- @property
- def t(self):
- pass
- @t.setter
- def t(self, value):
- pass
- @t.deleter
- def t(self):
- pass
- """)
- def test_unaryPlus(self):
- """Don't die on unary +."""
- self.flakes('+1')
- def test_undefinedBaseClass(self):
- """
- If a name in the base list of a class definition is undefined, a
- warning is emitted.
- """
- self.flakes('''
- class foo(foo):
- pass
- ''', m.UndefinedName)
- def test_classNameUndefinedInClassBody(self):
- """
- If a class name is used in the body of that class's definition and
- the name is not already defined, a warning is emitted.
- """
- self.flakes('''
- class foo:
- foo
- ''', m.UndefinedName)
- def test_classNameDefinedPreviously(self):
- """
- If a class name is used in the body of that class's definition and
- the name was previously defined in some other way, no warning is
- emitted.
- """
- self.flakes('''
- foo = None
- class foo:
- foo
- ''')
- def test_classRedefinition(self):
- """
- If a class is defined twice in the same module, a warning is emitted.
- """
- self.flakes('''
- class Foo:
- pass
- class Foo:
- pass
- ''', m.RedefinedWhileUnused)
- def test_functionRedefinedAsClass(self):
- """
- If a function is redefined as a class, a warning is emitted.
- """
- self.flakes('''
- def Foo():
- pass
- class Foo:
- pass
- ''', m.RedefinedWhileUnused)
- def test_classRedefinedAsFunction(self):
- """
- If a class is redefined as a function, a warning is emitted.
- """
- self.flakes('''
- class Foo:
- pass
- def Foo():
- pass
- ''', m.RedefinedWhileUnused)
- def test_classWithReturn(self):
- """
- If a return is used inside a class, a warning is emitted.
- """
- self.flakes('''
- class Foo(object):
- return
- ''', m.ReturnOutsideFunction)
- def test_moduleWithReturn(self):
- """
- If a return is used at the module level, a warning is emitted.
- """
- self.flakes('''
- return
- ''', m.ReturnOutsideFunction)
- def test_classWithYield(self):
- """
- If a yield is used inside a class, a warning is emitted.
- """
- self.flakes('''
- class Foo(object):
- yield
- ''', m.YieldOutsideFunction)
- def test_moduleWithYield(self):
- """
- If a yield is used at the module level, a warning is emitted.
- """
- self.flakes('''
- yield
- ''', m.YieldOutsideFunction)
- def test_classWithYieldFrom(self):
- """
- If a yield from is used inside a class, a warning is emitted.
- """
- self.flakes('''
- class Foo(object):
- yield from range(10)
- ''', m.YieldOutsideFunction)
- def test_moduleWithYieldFrom(self):
- """
- If a yield from is used at the module level, a warning is emitted.
- """
- self.flakes('''
- yield from range(10)
- ''', m.YieldOutsideFunction)
- def test_continueOutsideLoop(self):
- self.flakes('''
- continue
- ''', m.ContinueOutsideLoop)
- self.flakes('''
- def f():
- continue
- ''', m.ContinueOutsideLoop)
- self.flakes('''
- while True:
- pass
- else:
- continue
- ''', m.ContinueOutsideLoop)
- self.flakes('''
- while True:
- pass
- else:
- if 1:
- if 2:
- continue
- ''', m.ContinueOutsideLoop)
- self.flakes('''
- while True:
- def f():
- continue
- ''', m.ContinueOutsideLoop)
- self.flakes('''
- while True:
- class A:
- continue
- ''', m.ContinueOutsideLoop)
- def test_continueInsideLoop(self):
- self.flakes('''
- while True:
- continue
- ''')
- self.flakes('''
- for i in range(10):
- continue
- ''')
- self.flakes('''
- while True:
- if 1:
- continue
- ''')
- self.flakes('''
- for i in range(10):
- if 1:
- continue
- ''')
- self.flakes('''
- while True:
- while True:
- pass
- else:
- continue
- else:
- pass
- ''')
- self.flakes('''
- while True:
- try:
- pass
- finally:
- while True:
- continue
- ''')
- def test_breakOutsideLoop(self):
- self.flakes('''
- break
- ''', m.BreakOutsideLoop)
- self.flakes('''
- def f():
- break
- ''', m.BreakOutsideLoop)
- self.flakes('''
- while True:
- pass
- else:
- break
- ''', m.BreakOutsideLoop)
- self.flakes('''
- while True:
- pass
- else:
- if 1:
- if 2:
- break
- ''', m.BreakOutsideLoop)
- self.flakes('''
- while True:
- def f():
- break
- ''', m.BreakOutsideLoop)
- self.flakes('''
- while True:
- class A:
- break
- ''', m.BreakOutsideLoop)
- self.flakes('''
- try:
- pass
- finally:
- break
- ''', m.BreakOutsideLoop)
- def test_breakInsideLoop(self):
- self.flakes('''
- while True:
- break
- ''')
- self.flakes('''
- for i in range(10):
- break
- ''')
- self.flakes('''
- while True:
- if 1:
- break
- ''')
- self.flakes('''
- for i in range(10):
- if 1:
- break
- ''')
- self.flakes('''
- while True:
- while True:
- pass
- else:
- break
- else:
- pass
- ''')
- self.flakes('''
- while True:
- try:
- pass
- finally:
- while True:
- break
- ''')
- self.flakes('''
- while True:
- try:
- pass
- finally:
- break
- ''')
- self.flakes('''
- while True:
- try:
- pass
- finally:
- if 1:
- if 2:
- break
- ''')
- def test_defaultExceptLast(self):
- """
- A default except block should be last.
- YES:
- try:
- ...
- except Exception:
- ...
- except:
- ...
- NO:
- try:
- ...
- except:
- ...
- except Exception:
- ...
- """
- self.flakes('''
- try:
- pass
- except ValueError:
- pass
- ''')
- self.flakes('''
- try:
- pass
- except ValueError:
- pass
- except:
- pass
- ''')
- self.flakes('''
- try:
- pass
- except:
- pass
- ''')
- self.flakes('''
- try:
- pass
- except ValueError:
- pass
- else:
- pass
- ''')
- self.flakes('''
- try:
- pass
- except:
- pass
- else:
- pass
- ''')
- self.flakes('''
- try:
- pass
- except ValueError:
- pass
- except:
- pass
- else:
- pass
- ''')
- def test_defaultExceptNotLast(self):
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- except:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- except:
- pass
- except ValueError:
- pass
- ''', m.DefaultExceptNotLast, m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- else:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except:
- pass
- else:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- except:
- pass
- else:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- except:
- pass
- except ValueError:
- pass
- else:
- pass
- ''', m.DefaultExceptNotLast, m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- finally:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except:
- pass
- finally:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- except:
- pass
- finally:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- except:
- pass
- except ValueError:
- pass
- finally:
- pass
- ''', m.DefaultExceptNotLast, m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- else:
- pass
- finally:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except:
- pass
- else:
- pass
- finally:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- except:
- pass
- else:
- pass
- finally:
- pass
- ''', m.DefaultExceptNotLast)
- self.flakes('''
- try:
- pass
- except:
- pass
- except ValueError:
- pass
- except:
- pass
- except ValueError:
- pass
- else:
- pass
- finally:
- pass
- ''', m.DefaultExceptNotLast, m.DefaultExceptNotLast)
- def test_starredAssignmentNoError(self):
- """
- Python 3 extended iterable unpacking
- """
- self.flakes('''
- a, *b = range(10)
- ''')
- self.flakes('''
- *a, b = range(10)
- ''')
- self.flakes('''
- a, *b, c = range(10)
- ''')
- self.flakes('''
- (a, *b) = range(10)
- ''')
- self.flakes('''
- (*a, b) = range(10)
- ''')
- self.flakes('''
- (a, *b, c) = range(10)
- ''')
- self.flakes('''
- [a, *b] = range(10)
- ''')
- self.flakes('''
- [*a, b] = range(10)
- ''')
- self.flakes('''
- [a, *b, c] = range(10)
- ''')
- # Taken from test_unpack_ex.py in the cPython source
- s = ", ".join("a%d" % i for i in range(1 << 8 - 1)) + \
- ", *rest = range(1<<8)"
- self.flakes(s)
- s = "(" + ", ".join("a%d" % i for i in range(1 << 8 - 1)) + \
- ", *rest) = range(1<<8)"
- self.flakes(s)
- s = "[" + ", ".join("a%d" % i for i in range(1 << 8 - 1)) + \
- ", *rest] = range(1<<8)"
- self.flakes(s)
- def test_starredAssignmentErrors(self):
- """
- SyntaxErrors (not encoded in the ast) surrounding Python 3 extended
- iterable unpacking
- """
- # Taken from test_unpack_ex.py in the cPython source
- s = ", ".join("a%d" % i for i in range(1 << 8)) + \
- ", *rest = range(1<<8 + 1)"
- self.flakes(s, m.TooManyExpressionsInStarredAssignment)
- s = "(" + ", ".join("a%d" % i for i in range(1 << 8)) + \
- ", *rest) = range(1<<8 + 1)"
- self.flakes(s, m.TooManyExpressionsInStarredAssignment)
- s = "[" + ", ".join("a%d" % i for i in range(1 << 8)) + \
- ", *rest] = range(1<<8 + 1)"
- self.flakes(s, m.TooManyExpressionsInStarredAssignment)
- s = ", ".join("a%d" % i for i in range(1 << 8 + 1)) + \
- ", *rest = range(1<<8 + 2)"
- self.flakes(s, m.TooManyExpressionsInStarredAssignment)
- s = "(" + ", ".join("a%d" % i for i in range(1 << 8 + 1)) + \
- ", *rest) = range(1<<8 + 2)"
- self.flakes(s, m.TooManyExpressionsInStarredAssignment)
- s = "[" + ", ".join("a%d" % i for i in range(1 << 8 + 1)) + \
- ", *rest] = range(1<<8 + 2)"
- self.flakes(s, m.TooManyExpressionsInStarredAssignment)
- # No way we can actually test this!
- # s = "*rest, " + ", ".join("a%d" % i for i in range(1<<24)) + \
- # ", *rest = range(1<<24 + 1)"
- # self.flakes(s, m.TooManyExpressionsInStarredAssignment)
- self.flakes('''
- a, *b, *c = range(10)
- ''', m.TwoStarredExpressions)
- self.flakes('''
- a, *b, c, *d = range(10)
- ''', m.TwoStarredExpressions)
- self.flakes('''
- *a, *b, *c = range(10)
- ''', m.TwoStarredExpressions)
- self.flakes('''
- (a, *b, *c) = range(10)
- ''', m.TwoStarredExpressions)
- self.flakes('''
- (a, *b, c, *d) = range(10)
- ''', m.TwoStarredExpressions)
- self.flakes('''
- (*a, *b, *c) = range(10)
- ''', m.TwoStarredExpressions)
- self.flakes('''
- [a, *b, *c] = range(10)
- ''', m.TwoStarredExpressions)
- self.flakes('''
- [a, *b, c, *d] = range(10)
- ''', m.TwoStarredExpressions)
- self.flakes('''
- [*a, *b, *c] = range(10)
- ''', m.TwoStarredExpressions)
- @skip("todo: Too hard to make this warn but other cases stay silent")
- def test_doubleAssignment(self):
- """
- If a variable is re-assigned to without being used, no warning is
- emitted.
- """
- self.flakes('''
- x = 10
- x = 20
- ''', m.RedefinedWhileUnused)
- def test_doubleAssignmentConditionally(self):
- """
- If a variable is re-assigned within a conditional, no warning is
- emitted.
- """
- self.flakes('''
- x = 10
- if True:
- x = 20
- ''')
- def test_doubleAssignmentWithUse(self):
- """
- If a variable is re-assigned to after being used, no warning is
- emitted.
- """
- self.flakes('''
- x = 10
- y = x * 2
- x = 20
- ''')
- def test_comparison(self):
- """
- If a defined name is used on either side of any of the six comparison
- operators, no warning is emitted.
- """
- self.flakes('''
- x = 10
- y = 20
- x < y
- x <= y
- x == y
- x != y
- x >= y
- x > y
- ''')
- def test_identity(self):
- """
- If a defined name is used on either side of an identity test, no
- warning is emitted.
- """
- self.flakes('''
- x = 10
- y = 20
- x is y
- x is not y
- ''')
- def test_containment(self):
- """
- If a defined name is used on either side of a containment test, no
- warning is emitted.
- """
- self.flakes('''
- x = 10
- y = 20
- x in y
- x not in y
- ''')
- def test_loopControl(self):
- """
- break and continue statements are supported.
- """
- self.flakes('''
- for x in [1, 2]:
- break
- ''')
- self.flakes('''
- for x in [1, 2]:
- continue
- ''')
- def test_ellipsis(self):
- """
- Ellipsis in a slice is supported.
- """
- self.flakes('''
- [1, 2][...]
- ''')
- def test_extendedSlice(self):
- """
- Extended slices are supported.
- """
- self.flakes('''
- x = 3
- [1, 2][x,:]
- ''')
- def test_varAugmentedAssignment(self):
- """
- Augmented assignment of a variable is supported.
- We don't care about var refs.
- """
- self.flakes('''
- foo = 0
- foo += 1
- ''')
- def test_attrAugmentedAssignment(self):
- """
- Augmented assignment of attributes is supported.
- We don't care about attr refs.
- """
- self.flakes('''
- foo = None
- foo.bar += foo.baz
- ''')
- def test_globalDeclaredInDifferentScope(self):
- """
- A 'global' can be declared in one scope and reused in another.
- """
- self.flakes('''
- def f(): global foo
- def g(): foo = 'anything'; foo.is_used()
- ''')
- def test_function_arguments(self):
- """
- Test to traverse ARG and ARGUMENT handler
- """
- self.flakes('''
- def foo(a, b):
- pass
- ''')
- self.flakes('''
- def foo(a, b, c=0):
- pass
- ''')
- self.flakes('''
- def foo(a, b, c=0, *args):
- pass
- ''')
- self.flakes('''
- def foo(a, b, c=0, *args, **kwargs):
- pass
- ''')
- def test_function_arguments_python3(self):
- self.flakes('''
- def foo(a, b, c=0, *args, d=0, **kwargs):
- pass
- ''')
- class TestUnusedAssignment(TestCase):
- """
- Tests for warning about unused assignments.
- """
- def test_unusedVariable(self):
- """
- Warn when a variable in a function is assigned a value that's never
- used.
- """
- self.flakes('''
- def a():
- b = 1
- ''', m.UnusedVariable)
- def test_unusedUnderscoreVariable(self):
- """
- Don't warn when the magic "_" (underscore) variable is unused.
- See issue #202.
- """
- self.flakes('''
- def a(unused_param):
- _ = unused_param
- ''')
- def test_unusedVariableAsLocals(self):
- """
- Using locals() it is perfectly valid to have unused variables
- """
- self.flakes('''
- def a():
- b = 1
- return locals()
- ''')
- def test_unusedVariableNoLocals(self):
- """
- Using locals() in wrong scope should not matter
- """
- self.flakes('''
- def a():
- locals()
- def a():
- b = 1
- return
- ''', m.UnusedVariable)
- @skip("todo: Difficult because it doesn't apply in the context of a loop")
- def test_unusedReassignedVariable(self):
- """
- Shadowing a used variable can still raise an UnusedVariable warning.
- """
- self.flakes('''
- def a():
- b = 1
- b.foo()
- b = 2
- ''', m.UnusedVariable)
- def test_variableUsedInLoop(self):
- """
- Shadowing a used variable cannot raise an UnusedVariable warning in the
- context of a loop.
- """
- self.flakes('''
- def a():
- b = True
- while b:
- b = False
- ''')
- def test_assignToGlobal(self):
- """
- Assigning to a global and then not using that global is perfectly
- acceptable. Do not mistake it for an unused local variable.
- """
- self.flakes('''
- b = 0
- def a():
- global b
- b = 1
- ''')
- def test_assignToNonlocal(self):
- """
- Assigning to a nonlocal and then not using that binding is perfectly
- acceptable. Do not mistake it for an unused local variable.
- """
- self.flakes('''
- b = b'0'
- def a():
- nonlocal b
- b = b'1'
- ''')
- def test_assignToMember(self):
- """
- Assigning to a member of another object and then not using that member
- variable is perfectly acceptable. Do not mistake it for an unused
- local variable.
- """
- # XXX: Adding this test didn't generate a failure. Maybe not
- # necessary?
- self.flakes('''
- class b:
- pass
- def a():
- b.foo = 1
- ''')
- def test_assignInForLoop(self):
- """
- Don't warn when a variable in a for loop is assigned to but not used.
- """
- self.flakes('''
- def f():
- for i in range(10):
- pass
- ''')
- def test_assignInListComprehension(self):
- """
- Don't warn when a variable in a list comprehension is
- assigned to but not used.
- """
- self.flakes('''
- def f():
- [None for i in range(10)]
- ''')
- def test_generatorExpression(self):
- """
- Don't warn when a variable in a generator expression is
- assigned to but not used.
- """
- self.flakes('''
- def f():
- (None for i in range(10))
- ''')
- def test_assignmentInsideLoop(self):
- """
- Don't warn when a variable assignment occurs lexically after its use.
- """
- self.flakes('''
- def f():
- x = None
- for i in range(10):
- if i > 2:
- return x
- x = i * 2
- ''')
- def test_tupleUnpacking(self):
- """
- Don't warn when a variable included in tuple unpacking is unused. It's
- very common for variables in a tuple unpacking assignment to be unused
- in good Python code, so warning will only create false positives.
- """
- self.flakes('''
- def f(tup):
- (x, y) = tup
- ''')
- self.flakes('''
- def f():
- (x, y) = 1, 2
- ''', m.UnusedVariable, m.UnusedVariable)
- self.flakes('''
- def f():
- (x, y) = coords = 1, 2
- if x > 1:
- print(coords)
- ''')
- self.flakes('''
- def f():
- (x, y) = coords = 1, 2
- ''', m.UnusedVariable)
- self.flakes('''
- def f():
- coords = (x, y) = 1, 2
- ''', m.UnusedVariable)
- def test_listUnpacking(self):
- """
- Don't warn when a variable included in list unpacking is unused.
- """
- self.flakes('''
- def f(tup):
- [x, y] = tup
- ''')
- self.flakes('''
- def f():
- [x, y] = [1, 2]
- ''', m.UnusedVariable, m.UnusedVariable)
- def test_closedOver(self):
- """
- Don't warn when the assignment is used in an inner function.
- """
- self.flakes('''
- def barMaker():
- foo = 5
- def bar():
- return foo
- return bar
- ''')
- def test_doubleClosedOver(self):
- """
- Don't warn when the assignment is used in an inner function, even if
- that inner function itself is in an inner function.
- """
- self.flakes('''
- def barMaker():
- foo = 5
- def bar():
- def baz():
- return foo
- return bar
- ''')
- def test_tracebackhideSpecialVariable(self):
- """
- Do not warn about unused local variable __tracebackhide__, which is
- a special variable for py.test.
- """
- self.flakes("""
- def helper():
- __tracebackhide__ = True
- """)
- def test_ifexp(self):
- """
- Test C{foo if bar else baz} statements.
- """
- self.flakes("a = 'moo' if True else 'oink'")
- self.flakes("a = foo if True else 'oink'", m.UndefinedName)
- self.flakes("a = 'moo' if True else bar", m.UndefinedName)
- def test_if_tuple(self):
- """
- Test C{if (foo,)} conditions.
- """
- self.flakes("""if (): pass""")
- self.flakes("""
- if (
- True
- ):
- pass
- """)
- self.flakes("""
- if (
- True,
- ):
- pass
- """, m.IfTuple)
- self.flakes("""
- x = 1 if (
- True,
- ) else 2
- """, m.IfTuple)
- def test_withStatementNoNames(self):
- """
- No warnings are emitted for using inside or after a nameless C{with}
- statement a name defined beforehand.
- """
- self.flakes('''
- bar = None
- with open("foo"):
- bar
- bar
- ''')
- def test_withStatementSingleName(self):
- """
- No warnings are emitted for using a name defined by a C{with} statement
- within the suite or afterwards.
- """
- self.flakes('''
- with open('foo') as bar:
- bar
- bar
- ''')
- def test_withStatementAttributeName(self):
- """
- No warnings are emitted for using an attribute as the target of a
- C{with} statement.
- """
- self.flakes('''
- import foo
- with open('foo') as foo.bar:
- pass
- ''')
- def test_withStatementSubscript(self):
- """
- No warnings are emitted for using a subscript as the target of a
- C{with} statement.
- """
- self.flakes('''
- import foo
- with open('foo') as foo[0]:
- pass
- ''')
- def test_withStatementSubscriptUndefined(self):
- """
- An undefined name warning is emitted if the subscript used as the
- target of a C{with} statement is not defined.
- """
- self.flakes('''
- import foo
- with open('foo') as foo[bar]:
- pass
- ''', m.UndefinedName)
- def test_withStatementTupleNames(self):
- """
- No warnings are emitted for using any of the tuple of names defined by
- a C{with} statement within the suite or afterwards.
- """
- self.flakes('''
- with open('foo') as (bar, baz):
- bar, baz
- bar, baz
- ''')
- def test_withStatementListNames(self):
- """
- No warnings are emitted for using any of the list of names defined by a
- C{with} statement within the suite or afterwards.
- """
- self.flakes('''
- with open('foo') as [bar, baz]:
- bar, baz
- bar, baz
- ''')
- def test_withStatementComplicatedTarget(self):
- """
- If the target of a C{with} statement uses any or all of the valid forms
- for that part of the grammar (See
- U{http://docs.python.org/reference/compound_stmts.html#the-with-statement}),
- the names involved are checked both for definedness and any bindings
- created are respected in the suite of the statement and afterwards.
- """
- self.flakes('''
- c = d = e = g = h = i = None
- with open('foo') as [(a, b), c[d], e.f, g[h:i]]:
- a, b, c, d, e, g, h, i
- a, b, c, d, e, g, h, i
- ''')
- def test_withStatementSingleNameUndefined(self):
- """
- An undefined name warning is emitted if the name first defined by a
- C{with} statement is used before the C{with} statement.
- """
- self.flakes('''
- bar
- with open('foo') as bar:
- pass
- ''', m.UndefinedName)
- def test_withStatementTupleNamesUndefined(self):
- """
- An undefined name warning is emitted if a name first defined by the
- tuple-unpacking form of the C{with} statement is used before the
- C{with} statement.
- """
- self.flakes('''
- baz
- with open('foo') as (bar, baz):
- pass
- ''', m.UndefinedName)
- def test_withStatementSingleNameRedefined(self):
- """
- A redefined name warning is emitted if a name bound by an import is
- rebound by the name defined by a C{with} statement.
- """
- self.flakes('''
- import bar
- with open('foo') as bar:
- pass
- ''', m.RedefinedWhileUnused)
- def test_withStatementTupleNamesRedefined(self):
- """
- A redefined name warning is emitted if a name bound by an import is
- rebound by one of the names defined by the tuple-unpacking form of a
- C{with} statement.
- """
- self.flakes('''
- import bar
- with open('foo') as (bar, baz):
- pass
- ''', m.RedefinedWhileUnused)
- def test_withStatementUndefinedInside(self):
- """
- An undefined name warning is emitted if a name is used inside the
- body of a C{with} statement without first being bound.
- """
- self.flakes('''
- with open('foo') as bar:
- baz
- ''', m.UndefinedName)
- def test_withStatementNameDefinedInBody(self):
- """
- A name defined in the body of a C{with} statement can be used after
- the body ends without warning.
- """
- self.flakes('''
- with open('foo') as bar:
- baz = 10
- baz
- ''')
- def test_withStatementUndefinedInExpression(self):
- """
- An undefined name warning is emitted if a name in the I{test}
- expression of a C{with} statement is undefined.
- """
- self.flakes('''
- with bar as baz:
- pass
- ''', m.UndefinedName)
- self.flakes('''
- with bar as bar:
- pass
- ''', m.UndefinedName)
- def test_dictComprehension(self):
- """
- Dict comprehensions are properly handled.
- """
- self.flakes('''
- a = {1: x for x in range(10)}
- ''')
- def test_setComprehensionAndLiteral(self):
- """
- Set comprehensions are properly handled.
- """
- self.flakes('''
- a = {1, 2, 3}
- b = {x for x in range(10)}
- ''')
- def test_exceptionUsedInExcept(self):
- self.flakes('''
- try: pass
- except Exception as e: e
- ''')
- self.flakes('''
- def download_review():
- try: pass
- except Exception as e: e
- ''')
- def test_exceptionUnusedInExcept(self):
- self.flakes('''
- try: pass
- except Exception as e: pass
- ''', m.UnusedVariable)
- @skipIf(version_info < (3, 11), 'new in Python 3.11')
- def test_exception_unused_in_except_star(self):
- self.flakes('''
- try:
- pass
- except* OSError as e:
- pass
- ''', m.UnusedVariable)
- def test_exceptionUnusedInExceptInFunction(self):
- self.flakes('''
- def download_review():
- try: pass
- except Exception as e: pass
- ''', m.UnusedVariable)
- def test_exceptWithoutNameInFunction(self):
- """
- Don't issue false warning when an unnamed exception is used.
- Previously, there would be a false warning, but only when the
- try..except was in a function
- """
- self.flakes('''
- import tokenize
- def foo():
- try: pass
- except tokenize.TokenError: pass
- ''')
- def test_exceptWithoutNameInFunctionTuple(self):
- """
- Don't issue false warning when an unnamed exception is used.
- This example catches a tuple of exception types.
- """
- self.flakes('''
- import tokenize
- def foo():
- try: pass
- except (tokenize.TokenError, IndentationError): pass
- ''')
- def test_augmentedAssignmentImportedFunctionCall(self):
- """
- Consider a function that is called on the right part of an
- augassign operation to be used.
- """
- self.flakes('''
- from foo import bar
- baz = 0
- baz += bar()
- ''')
- def test_assert_without_message(self):
- """An assert without a message is not an error."""
- self.flakes('''
- a = 1
- assert a
- ''')
- def test_assert_with_message(self):
- """An assert with a message is not an error."""
- self.flakes('''
- a = 1
- assert a, 'x'
- ''')
- def test_assert_tuple(self):
- """An assert of a non-empty tuple is always True."""
- self.flakes('''
- assert (False, 'x')
- assert (False, )
- ''', m.AssertTuple, m.AssertTuple)
- def test_assert_tuple_empty(self):
- """An assert of an empty tuple is always False."""
- self.flakes('''
- assert ()
- ''')
- def test_assert_static(self):
- """An assert of a static value is not an error."""
- self.flakes('''
- assert True
- assert 1
- ''')
- def test_yieldFromUndefined(self):
- """
- Test C{yield from} statement
- """
- self.flakes('''
- def bar():
- yield from foo()
- ''', m.UndefinedName)
- def test_f_string(self):
- """Test PEP 498 f-strings are treated as a usage."""
- self.flakes('''
- baz = 0
- print(f'\x7b4*baz\N{RIGHT CURLY BRACKET}')
- ''')
- def test_assign_expr(self):
- """Test PEP 572 assignment expressions are treated as usage / write."""
- self.flakes('''
- from foo import y
- print(x := y)
- print(x)
- ''')
- def test_assign_expr_generator_scope(self):
- """Test assignment expressions in generator expressions."""
- self.flakes('''
- if (any((y := x[0]) for x in [[True]])):
- print(y)
- ''')
- def test_assign_expr_nested(self):
- """Test assignment expressions in nested expressions."""
- self.flakes('''
- if ([(y:=x) for x in range(4) if [(z:=q) for q in range(4)]]):
- print(y)
- print(z)
- ''')
- class TestStringFormatting(TestCase):
- def test_f_string_without_placeholders(self):
- self.flakes("f'foo'", m.FStringMissingPlaceholders)
- self.flakes('''
- f"""foo
- bar
- """
- ''', m.FStringMissingPlaceholders)
- self.flakes('''
- print(
- f'foo'
- f'bar'
- )
- ''', m.FStringMissingPlaceholders)
- # this is an "escaped placeholder" but not a placeholder
- self.flakes("f'{{}}'", m.FStringMissingPlaceholders)
- # ok: f-string with placeholders
- self.flakes('''
- x = 5
- print(f'{x}')
- ''')
- # ok: f-string with format specifiers
- self.flakes('''
- x = 'a' * 90
- print(f'{x:.8}')
- ''')
- # ok: f-string with multiple format specifiers
- self.flakes('''
- x = y = 5
- print(f'{x:>2} {y:>2}')
- ''')
- def test_invalid_dot_format_calls(self):
- self.flakes('''
- '{'.format(1)
- ''', m.StringDotFormatInvalidFormat)
- self.flakes('''
- '{} {1}'.format(1, 2)
- ''', m.StringDotFormatMixingAutomatic)
- self.flakes('''
- '{0} {}'.format(1, 2)
- ''', m.StringDotFormatMixingAutomatic)
- self.flakes('''
- '{}'.format(1, 2)
- ''', m.StringDotFormatExtraPositionalArguments)
- self.flakes('''
- '{}'.format(1, bar=2)
- ''', m.StringDotFormatExtraNamedArguments)
- self.flakes('''
- '{} {}'.format(1)
- ''', m.StringDotFormatMissingArgument)
- self.flakes('''
- '{2}'.format()
- ''', m.StringDotFormatMissingArgument)
- self.flakes('''
- '{bar}'.format()
- ''', m.StringDotFormatMissingArgument)
- # too much string recursion (placeholder-in-placeholder)
- self.flakes('''
- '{:{:{}}}'.format(1, 2, 3)
- ''', m.StringDotFormatInvalidFormat)
- # ok: dotted / bracketed names need to handle the param differently
- self.flakes("'{.__class__}'.format('')")
- self.flakes("'{foo[bar]}'.format(foo={'bar': 'barv'})")
- # ok: placeholder-placeholders
- self.flakes('''
- print('{:{}} {}'.format(1, 15, 2))
- ''')
- # ok: not a placeholder-placeholder
- self.flakes('''
- print('{:2}'.format(1))
- ''')
- # ok: not mixed automatic
- self.flakes('''
- '{foo}-{}'.format(1, foo=2)
- ''')
- # ok: we can't determine statically the format args
- self.flakes('''
- a = ()
- "{}".format(*a)
- ''')
- self.flakes('''
- k = {}
- "{foo}".format(**k)
- ''')
- def test_invalid_percent_format_calls(self):
- self.flakes('''
- '%(foo)' % {'foo': 'bar'}
- ''', m.PercentFormatInvalidFormat)
- self.flakes('''
- '%s %(foo)s' % {'foo': 'bar'}
- ''', m.PercentFormatMixedPositionalAndNamed)
- self.flakes('''
- '%(foo)s %s' % {'foo': 'bar'}
- ''', m.PercentFormatMixedPositionalAndNamed)
- self.flakes('''
- '%j' % (1,)
- ''', m.PercentFormatUnsupportedFormatCharacter)
- self.flakes('''
- '%s %s' % (1,)
- ''', m.PercentFormatPositionalCountMismatch)
- self.flakes('''
- '%s %s' % (1, 2, 3)
- ''', m.PercentFormatPositionalCountMismatch)
- self.flakes('''
- '%(bar)s' % {}
- ''', m.PercentFormatMissingArgument,)
- self.flakes('''
- '%(bar)s' % {'bar': 1, 'baz': 2}
- ''', m.PercentFormatExtraNamedArguments)
- self.flakes('''
- '%(bar)s' % (1, 2, 3)
- ''', m.PercentFormatExpectedMapping)
- self.flakes('''
- '%s %s' % {'k': 'v'}
- ''', m.PercentFormatExpectedSequence)
- self.flakes('''
- '%(bar)*s' % {'bar': 'baz'}
- ''', m.PercentFormatStarRequiresSequence)
- # ok: single %s with mapping
- self.flakes('''
- '%s' % {'foo': 'bar', 'baz': 'womp'}
- ''')
- # ok: does not cause a MemoryError (the strings aren't evaluated)
- self.flakes('''
- "%1000000000000f" % 1
- ''')
- # ok: %% should not count towards placeholder count
- self.flakes('''
- '%% %s %% %s' % (1, 2)
- ''')
- # ok: * consumes one positional argument
- self.flakes('''
- '%.*f' % (2, 1.1234)
- '%*.*f' % (5, 2, 3.1234)
- ''')
- def test_ok_percent_format_cannot_determine_element_count(self):
- self.flakes('''
- a = []
- '%s %s' % [*a]
- '%s %s' % (*a,)
- ''')
- self.flakes('''
- k = {}
- '%(k)s' % {**k}
- ''')
- class TestAsyncStatements(TestCase):
- def test_asyncDef(self):
- self.flakes('''
- async def bar():
- return 42
- ''')
- def test_asyncDefAwait(self):
- self.flakes('''
- async def read_data(db):
- await db.fetch('SELECT ...')
- ''')
- def test_asyncDefUndefined(self):
- self.flakes('''
- async def bar():
- return foo()
- ''', m.UndefinedName)
- def test_asyncFor(self):
- self.flakes('''
- async def read_data(db):
- output = []
- async for row in db.cursor():
- output.append(row)
- return output
- ''')
- def test_asyncForUnderscoreLoopVar(self):
- self.flakes('''
- async def coro(it):
- async for _ in it:
- pass
- ''')
- def test_loopControlInAsyncFor(self):
- self.flakes('''
- async def read_data(db):
- output = []
- async for row in db.cursor():
- if row[0] == 'skip':
- continue
- output.append(row)
- return output
- ''')
- self.flakes('''
- async def read_data(db):
- output = []
- async for row in db.cursor():
- if row[0] == 'stop':
- break
- output.append(row)
- return output
- ''')
- def test_loopControlInAsyncForElse(self):
- self.flakes('''
- async def read_data(db):
- output = []
- async for row in db.cursor():
- output.append(row)
- else:
- continue
- return output
- ''', m.ContinueOutsideLoop)
- self.flakes('''
- async def read_data(db):
- output = []
- async for row in db.cursor():
- output.append(row)
- else:
- break
- return output
- ''', m.BreakOutsideLoop)
- def test_asyncWith(self):
- self.flakes('''
- async def commit(session, data):
- async with session.transaction():
- await session.update(data)
- ''')
- def test_asyncWithItem(self):
- self.flakes('''
- async def commit(session, data):
- async with session.transaction() as trans:
- await trans.begin()
- ...
- await trans.end()
- ''')
- def test_matmul(self):
- self.flakes('''
- def foo(a, b):
- return a @ b
- ''')
- def test_formatstring(self):
- self.flakes('''
- hi = 'hi'
- mom = 'mom'
- f'{hi} {mom}'
- ''')
- def test_raise_notimplemented(self):
- self.flakes('''
- raise NotImplementedError("This is fine")
- ''')
- self.flakes('''
- raise NotImplementedError
- ''')
- self.flakes('''
- raise NotImplemented("This isn't gonna work")
- ''', m.RaiseNotImplemented)
- self.flakes('''
- raise NotImplemented
- ''', m.RaiseNotImplemented)
- class TestIncompatiblePrintOperator(TestCase):
- """
- Tests for warning about invalid use of print function.
- """
- def test_valid_print(self):
- self.flakes('''
- print("Hello")
- ''')
- def test_invalid_print_when_imported_from_future(self):
- exc = self.flakes('''
- from __future__ import print_function
- import sys
- print >>sys.stderr, "Hello"
- ''', m.InvalidPrintSyntax).messages[0]
- self.assertEqual(exc.lineno, 4)
- self.assertEqual(exc.col, 0)
- def test_print_augmented_assign(self):
- # nonsense, but shouldn't crash pyflakes
- self.flakes('print += 1')
- def test_print_function_assignment(self):
- """
- A valid assignment, tested for catching false positives.
- """
- self.flakes('''
- from __future__ import print_function
- log = print
- log("Hello")
- ''')
- def test_print_in_lambda(self):
- self.flakes('''
- from __future__ import print_function
- a = lambda: print
- ''')
- def test_print_returned_in_function(self):
- self.flakes('''
- from __future__ import print_function
- def a():
- return print
- ''')
- def test_print_as_condition_test(self):
- self.flakes('''
- from __future__ import print_function
- if print: pass
- ''')
|